Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] #57 - 사진인증 플로우 및 케이스별 업로드페이지 구현 #69

Merged
merged 14 commits into from
Jan 15, 2022

Conversation

L-j-h-c
Copy link
Member

@L-j-h-c L-j-h-c commented Jan 15, 2022

🌴 PR 요약

🌱 작업한 브랜치

🌱 작업한 내용

  • 사진인증 플로우 및 케이스별 업로드페이지 구현
  • 케이스별 업로드페이지 구현

📌 참고 사항

  • 사진인증 플로우에서 케이스별 화면전환 기능은 추후 구현
  • 사진인증 플로우에서 케이스별 이미지 변화는 추후 구현
  • 업로드페이지 내비바 추후 구현
  • 업로드페이지는 enum케이스 보시고 이전 화면에서 프로퍼티 데이터전달해서 사용하시면 됩니다.

📸 스크린샷

기능 스크린샷
GIF Simulator Screen Recording - iPhone 11 Pro - 2022-01-16 at 03 40 56

📮 관련 이슈

@L-j-h-c L-j-h-c added Feat 새로운 기능 구현 🧚‍♀️Devil『쥬노』 뀨의 의지 공식후계자입니다 아몰랑 P1 / Priority High labels Jan 15, 2022
@L-j-h-c L-j-h-c self-assigned this Jan 15, 2022
@L-j-h-c L-j-h-c changed the title [Feat] 사진인증 플로우 및 케이스별 업로드페이지 구현 [Feat] #57 - 사진인증 플로우 및 케이스별 업로드페이지 구현 Jan 15, 2022
Copy link
Member

@yangsubinn yangsubinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨슴다💐

Comment on lines +48 to +51
timerLabel.text = "00:30:12"
timerLabel.font = .enBoldFont(ofSize: 40)
timerLabel.textColor = .sparkWhite

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기는 저를 위한 친구인건가여? 감삼다

Comment on lines +68 to +85
switch vcType
{
case .cameraOnly:
print("카메라")
timerLabel.isHidden = true

case .albumOnly:
print("앨범")
retakeButton.setTitle("다시 선택", for: .normal)
timerLabel.isHidden = true

case .cameraTimer:
print("카메라타이머")

case .albumTimer:
print("앨범타이머")
retakeButton.setTitle("다시 선택", for: .normal)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cameraOnly와 cameraTimer는 어떤 경우에 쓰이는 부분인가여?..?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

일단 사진인증과 앨범인증에서 retakeButton의 텍스트가 다시 찍기와 다시 선택으로 달라요! 그리고 타이머가 있는 경우에 라벨이 보여야 하기 때문에 분기처리 해주었습니다

Comment on lines +117 to +130
switch vcType
{
case .cameraOnly:
print("")

case .albumOnly:
print("")

case .cameraTimer:
print("")

case .albumTimer:
print("")
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이건 모죠?..?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

나중을 위한 대비...로 뒀는데 의미없는것같네용

@L-j-h-c L-j-h-c merged commit fbb4427 into TeamSparker:develop Jan 15, 2022
Comment on lines +5 to +8
<key>NSPhotoLibraryUsageDescription</key>
<string>test</string>
<key>NSCameraUsageDescription</key>
<string>test</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아요 선생님!~ test 부분에 들어갈 멘트가 픽스되어 말씀드립니다~!
카메라 인증시 :  '사진을 촬영하여 첨부할 수 있습니다.'
앨범 인증시 : '사진을 선택하여 첨부할 수 있습니다.'
프로필 설정시에도 각각 동일한 멘트로 해주시면 될것 같아효~!

라고 슬랙에 답주셨네용 전달드립니당

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다 수정했어요!


// TODO: 고민중, 쉴래요 버튼 기능 구현
considerButton.setTitleColor(.sparkLightPinkred, for: .highlighted)
considerButton.layer.borderColor = .init(_colorLiteralRed: 1, green: 137/255, blue: 165/255, alpha: 1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uicolor 익스텐션한거 사용해주세여! sparkLightGray 인거 같네여!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이상하게 보더컬러로 사용하면 안 불러와지네요.. 라고 생각했는데
considerButton.layer.borderColor = UIColor.sparkLightGray.cgColor
이렇게 하니까 잘 됩니다.. 감사합니당!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😉

considerButton.layer.cornerRadius = 2

restButton.setTitleColor(.sparkLightPinkred, for: .highlighted)
restButton.layer.borderColor = .init(_colorLiteralRed: 1, green: 137/255, blue: 165/255, alpha: 1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이친구도요~

Comment on lines +73 to +78
let library = UIAlertAction(title: "카메라 촬영", style: .default) { action in
self.openCamera()
}
let camera = UIAlertAction(title: "앨범에서 선택하기", style: .default) { action in
self.openLibrary()
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네이밍 맞추서 변경해주세요~!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영했습니다!


// MARK: - Properties

var vcType: VCCase = .cameraTimer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추후에 수정할때는 cameraTimer 로 지정해주지 말구 데이터 전달받아서 switch 문에서 4가지 경우 다 포함해서 짜면 좋을거 같아여 지금은 뭐 다시찍기 이런것도 setUI() 에서 기본으로 지정하고 있는데 뒤에 스위치문에서 다시 지정하는 경우가 생길수도 있으니까여 @Frozen 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

프로즌 선배 잘 썼습니다! 수정 시에 재지정 하는 케이스 줄일 수 있도록 케이스마다 적용해보겠습니다!

Copy link
Member Author

@L-j-h-c L-j-h-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 감사합니다 슨배들!!

Comment on lines +5 to +8
<key>NSPhotoLibraryUsageDescription</key>
<string>test</string>
<key>NSCameraUsageDescription</key>
<string>test</string>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다 수정했어요!


// TODO: 고민중, 쉴래요 버튼 기능 구현
considerButton.setTitleColor(.sparkLightPinkred, for: .highlighted)
considerButton.layer.borderColor = .init(_colorLiteralRed: 1, green: 137/255, blue: 165/255, alpha: 1)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이상하게 보더컬러로 사용하면 안 불러와지네요.. 라고 생각했는데
considerButton.layer.borderColor = UIColor.sparkLightGray.cgColor
이렇게 하니까 잘 됩니다.. 감사합니당!

Comment on lines +73 to +78
let library = UIAlertAction(title: "카메라 촬영", style: .default) { action in
self.openCamera()
}
let camera = UIAlertAction(title: "앨범에서 선택하기", style: .default) { action in
self.openLibrary()
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영했습니다!


// MARK: - Properties

var vcType: VCCase = .cameraTimer
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

프로즌 선배 잘 썼습니다! 수정 시에 재지정 하는 케이스 줄일 수 있도록 케이스마다 적용해보겠습니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧚‍♀️Devil『쥬노』 뀨의 의지 공식후계자입니다 아몰랑 Feat 새로운 기능 구현 P1 / Priority High
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] 사진 인증 플로우 구현
3 participants