[Feat] #78 - 로티 인스톨 및 티켓 애니메이션 구현 #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
로티 라이브러리 설치
로티 제이슨 파일 추가
인증완료 로티 추가
티켓 로티 추가
접근제한자 수정
L-j-h-c
added
Feat
hyun99999
reviewed
Jan 17, 2022
| let animationView = AnimationView(name: "ticket_welcome") | ||
| animationView.frame = animationFrameView.bounds | ||
| animationView.contentMode = .scaleAspectFit | ||
| animationView.loopMode = .repeat(100) |
There was a problem hiding this comment.
lazy 는 만들어지기 전에는 메모리에 올리지 않는 이점이 있는데 이 뷰는 이미 올라가있기 때문에 불필요해보여여!
There was a problem hiding this comment.
그 loop선배를 못찾았었는데... 있네요 ㅎㅎ 감사합니다 lazy는 수정했습니다!
Comment on lines
+75
to
+77
| DispatchQueue.main.asyncAfter(deadline: DispatchTime.now() + 1) { [self] in | ||
| ticketView.play() | ||
| } |
There was a problem hiding this comment.
네 맞아요! 이후에 적당한 간격으로 수정했습니다
|
|
||
| class JoinCheckVC: UIViewController { | ||
|
|
||
| // MARK: - Properties | ||
|
|
||
| lazy var ticketView: AnimationView = { | ||
| let animationView = AnimationView(name: "ticket_welcome") |
| @@ -20,6 +32,8 @@ class CompleteAuthVC: UIViewController { | |||
| super.viewDidLoad() | |||
| setUI() | |||
| setGesture() | |||
| setAnimation() | |||
| view.bringSubviewToFront(handImageVIew) | |||
Lottie const 추가 및 적용
코드리뷰 반영
hyun99999
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 PR 요약
🌱 작업한 브랜치
🌱 작업한 내용
📌 참고 사항
📮 관련 이슈