[Feat] #68 - 스톱워치 + 사진 인증하기 중 사진인증 뷰 구현 #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangsubinn
added
🚨review_required🚨
hyun99999
approved these changes
Jan 17, 2022
Comment on lines
+233
to
+235
| func imagePickerControllerDidCancel(_ picker: UIImagePickerController) { | ||
| self.dismiss(animated: true, completion: nil) | ||
| } |
Comment on lines
+302
to
+303
| make.bottom.equalTo(view.safeAreaLayoutGuide).inset(10) | ||
| make.height.equalTo(self.view.frame.width*48/335) |
L-j-h-c
approved these changes
Jan 17, 2022
| @@ -55,7 +90,7 @@ extension AuthUploadVC { | |||
| retakeButton.backgroundColor = .sparkWhite | |||
| retakeButton.tintColor = .sparkDarkPinkred | |||
| retakeButton.setTitleColor(.sparkDarkPinkred, for: .normal) | |||
| retakeButton.layer.borderWidth = 1 | |||
| retakeButton.layer.borderWidth = 2 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 PR 요약
🌱 작업한 브랜치
🌱 작업한 내용
📌 참고 사항
uploadImageView가 조금 이상한 친구입니다.
사진을 가져왔을때 aspectToFill이 적용이 안돼서
uploadImageView.layer.masksToBounds = true이걸 일단 적용시켰고 제대로 작용을 하는 상황입니다
📸 스크린샷
📮 관련 이슈