[Feat] #80 - 대기방 서버 연결 #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangsubinn
added
Feat
L-j-h-c
approved these changes
Jan 17, 2022
| if let waitingRoom = data as? Waiting { | ||
| var user: ReqUser | ||
|
|
||
| self.navigationController?.initWithTitle(title: "\(waitingRoom.roomName)", tintColor: .sparkBlack, backgroundColor: .sparkWhite) |
There was a problem hiding this comment.
넹 근데 요 친구는 사실 제대로 작동하는지 확인해보지 않아서 나중에 네비바 연결할 때 한 번에 정리해봐야될 것 같아요!
Comment on lines
+199
to
+203
| if waitingRoom.fromStart { | ||
| [self.stopwatchLabel, self.checkDivideView].forEach { $0.isHidden = false } | ||
| } else { | ||
| [self.stopwatchLabel, self.checkDivideView].forEach { $0.isHidden = true } | ||
| } |
Comment on lines
+224
to
+237
| if user.profileImg != nil { | ||
| if let url = URL(string: user.profileImg ?? "") { | ||
| do { | ||
| let data = try Data(contentsOf: url) | ||
| self.profileImageView.image = UIImage(data: data) | ||
| } catch { | ||
| self.profileImageView.image = UIImage(named: "profileEmpty") | ||
| self.profileImageView.backgroundColor = .sparkGray | ||
| } | ||
| } | ||
| } else { | ||
| self.profileImageView.image = UIImage(named: "profileEmpty") | ||
| self.profileImageView.backgroundColor = .sparkGray | ||
| } |
There was a problem hiding this comment.
덕분에 try와 do catch를 이용한 오류 처리 공부하고 갑니다...! 프로필이미지가 있는지, url이 제대로 전달되었는지에 따라 분기처리해주셨군요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 PR 요약
🌱 작업한 브랜치
🌱 작업한 내용
📌 참고 사항
프로필 이미지 부분은 서버에서 디폴트 이미지를 보내주신다고 했는데, nil 값으로 들어와서 일단은 nil 값이 들어온다는 가정 하에 로직 짰습니다.
디폴트 이미지까지 url로 야무지게 들어오면 initCell을 제대로 수정해보겠습니다.
추가 말할 것이 있었는데 깜빡했슴니다....
이전에 스톱워치 + 사진 중 사진 인증 플로우 커밋까지 포함되어 있어서 쫌 많은데!
이전꺼 머지하고 봐주시면 감사하겠습니다!
📸 스크린샷
📮 관련 이슈