Fix typings incorrectly exported as defaults #14
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8
At runtime, the module with the style mapping is a commonjs module which exports the values using
module.exports
. In order to get the typings working for exporting theinterface
, thelocals
and the mapping keys, we were usingexport default
as a hack. Which turns out to be problematic in some configurations (see #8) and leads to either failing type check or runtime errors. Instead of usingexport default
, we can leverage TypeScript declaration merging - useconst
andnamespace
and withexport =
.Example:
This type declaration allows the following usage: