Favor using full colors instead of light for Material Ui Next beta 30 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leaexplores
force-pushed
the
hotfix/material-ui-30
branch
from
a103fdb
to
249bcd9
Compare
|
Thanks a lot for this PR, but let's stick to the Material Design Guidelines and keep the font colors. 😉 I don't know why they removed colors that were clearly specified in the Guidelines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The color palette of material ui was recently revamped in v1.0.0-beta.30.
The light tint does not exist anymore and the mui favors using the default tint.
Instead of going 💥 , we should favor the default tint for black and white that come from the palette.
Related PR :
mui/material-ui#9876
mui/material-ui#9918
mui/material-ui#9970