-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update role models (fix issue #61) #63
base: staging
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Any new or changed endpoints should be thoroughly documented.
- Write and or update tests for your new / updated endpoints.
- All code should be easly readable or commented.
If your code does not meet these requirements your PR will not be accepted.
Based on the error i guessed that changing the hex ints color values to strings may fix this -> https://github.com/Tech-With-Tim/API/pull/63/checks?check_run_id=3842105193. I am not sure. So i did fb82222 |
@Tech-With-Tim/project-lead Thoughs on subclassing the |
We could just add a validator for colors, to try to use |
@takos22 why wait for it to raise a |
And did the conversion from int to string in fb82222 not remove that error? |
I'm sorry for 2 same commits :cheemsdorime: but it was by accident |
Can one of you run lints and tests when u are back? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the tests and the database queries
@KrishnaKanth1729 any updates? |
@KrishnaKanth1729 can we get this fixed soon? |
what do we do? |
@KrishnaKanth1729 Fix the tests, you can use int in the role response model |
Summary
Resolve Issue #61
Checklist