-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go: Updated to 1.5.2 & Added fasthttp benchmark #1765
Conversation
…prove performance on Peak hardware
…ng transaction' error by sorting rows by id before updating them in a transaction
@valyala local tests are failing |
Fasthttp requires at least go1.5, while the benchmark uses older Go version (1.4.2) :( So the following build errors appear:
Is it possible updating go version in the benchmark to the latest one? |
@msmith-techempower , done |
I see that - this will probably effect all the various Go frameworks - a full Travis run will be required, but because Travis is broken on master, it won't work. Once #1786 is merged in, you will need to merge it into your branch (or rebase your branch; I don't really care). |
Is it possible to manually check all Go frameworks? I did check them few weeks ago on go 1.5.1 - it looks like nothing breaks. |
BTW, go1.5 has huge latency improvements comparing to go1.4 - see this article for details. |
@valyala I am working on testing the Go frameworks now |
Go 1.5.2 is out. It contains many bugfixes, including the bugfix for the nasty bug. So I updated go version to 1.5.2. |
@valyala Can you rebase off of master (or merge master into your branch, if that is easier) just to ensure that you have the latest Travis fixes? |
@msmith-techempower , done! |
Passed all the tests: https://travis-ci.org/TechEmpower/FrameworkBenchmarks/jobs/96284048 LGTM! |
Go: Updated to 1.5.2 & Added fasthttp benchmark
fasthttp is much faster than go's net/http