Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go: Updated to 1.5.2 & Added fasthttp benchmark #1765

Merged
merged 20 commits into from
Dec 11, 2015

Conversation

valyala
Copy link
Contributor

@valyala valyala commented Nov 17, 2015

fasthttp is much faster than go's net/http

@valyala valyala changed the title Added initial fasthttp benchmark Added fasthttp benchmark Nov 19, 2015
@NateBrady23
Copy link
Member

@valyala local tests are failing
Logs - http://sprunge.us/OdND

@valyala
Copy link
Contributor Author

valyala commented Dec 2, 2015

Fasthttp requires at least go1.5, while the benchmark uses older Go version (1.4.2) :(

So the following build errors appear:

Setup fasthttp: src/github.com/valyala/fasthttp/bytesconv.go:24: date.In(gmtLocation).AppendFormat undefined (type time.Time has no field or method AppendFormat)
Setup fasthttp: src/github.com/valyala/fasthttp/header.go:1171: undefined: bytes.LastIndexByte
Setup fasthttp: src/github.com/valyala/fasthttp/header.go:1496: r.Discard undefined (type *bufio.Reader has no field or method Discard)
Setup fasthttp: src/github.com/valyala/fasthttp/http.go:544: undefined: io.CopyBuffer
Setup fasthttp: src/github.com/valyala/fasthttp/uri.go:257: undefined: bytes.LastIndexByte
Setup fasthttp: src/github.com/valyala/fasthttp/uri.go:269: undefined: bytes.LastIndexByte

Is it possible updating go version in the benchmark to the latest one?

@msmith-techempower
Copy link
Member

@valyala This file should be the one to update to get the latest Go version.

@valyala
Copy link
Contributor Author

valyala commented Dec 2, 2015

@msmith-techempower , done

@msmith-techempower
Copy link
Member

I see that - this will probably effect all the various Go frameworks - a full Travis run will be required, but because Travis is broken on master, it won't work.

Once #1786 is merged in, you will need to merge it into your branch (or rebase your branch; I don't really care).

@valyala
Copy link
Contributor Author

valyala commented Dec 2, 2015

Is it possible to manually check all Go frameworks? I did check them few weeks ago on go 1.5.1 - it looks like nothing breaks.

@valyala
Copy link
Contributor Author

valyala commented Dec 2, 2015

BTW, go1.5 has huge latency improvements comparing to go1.4 - see this article for details.

@NateBrady23
Copy link
Member

@valyala I am working on testing the Go frameworks now

@NateBrady23
Copy link
Member

@valyala strike that - waiting for #1786 then will complete the tests

@NateBrady23 NateBrady23 changed the title Added fasthttp benchmark Go: Updated to 1.5.1 & Added fasthttp benchmark Dec 2, 2015
@NateBrady23 NateBrady23 mentioned this pull request Dec 2, 2015
@valyala valyala changed the title Go: Updated to 1.5.1 & Added fasthttp benchmark Go: Updated to 1.5.2 & Added fasthttp benchmark Dec 8, 2015
@valyala
Copy link
Contributor Author

valyala commented Dec 8, 2015

Go 1.5.2 is out. It contains many bugfixes, including the bugfix for the nasty bug. So I updated go version to 1.5.2.

@msmith-techempower
Copy link
Member

@valyala Can you rebase off of master (or merge master into your branch, if that is easier) just to ensure that you have the latest Travis fixes?

@valyala
Copy link
Contributor Author

valyala commented Dec 11, 2015

@msmith-techempower , done!

@msmith-techempower
Copy link
Member

msmith-techempower added a commit that referenced this pull request Dec 11, 2015
Go: Updated to 1.5.2 & Added fasthttp benchmark
@msmith-techempower msmith-techempower merged commit 93e7df0 into TechEmpower:master Dec 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants