Symfony - persistent connections #5045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
force-pushed
the
symfony-persist
branch
from
a8cee8c to
35c720c
Compare
|
Sounds good to me. |
|
@jderusse Remove the |
jderusse
changed the title
|
Ready to merge @nbrady-techempower |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current TestSuite is failing because of number of connection to the database.
The solution is to use "persistent connection", but this is not currently supported by Doctrine (see doctrine/dbal#2315) because setting ATTR_PERSISTENT conflict with ATTR_STATEMENT_CLASS.
nb: This issue has been fixed in Doctrine 3 (not yet released nor installable)
This PR patch doctrine to support persistent connection in PHP/symfony
note: Drawback is: caching results won't works anymore. Which not an issue in our case because caching result is not permitted in the benchmark.
This PR also replaces calls to aliases by a call to the original method. Less function calls === more performances. Tell me if you prefer a dedicated PR
ping @raziel057 @kaznovac