[go] Chi remove extra tests #8214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip]
franz1981
pushed a commit
to franz1981/FrameworkBenchmarks
that referenced
this pull request
Jun 23, 2023
* [go] Chi remove extra tests [ci skip] * Add to display name "prefork" to some Go frameworks [ci skip]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gojay and sjson, are Json libs than return the same results for tests not using Json (Fortunes and Plaintext). #8178
Another question here, is it necessary to test these json libs with and without prefork?
Any framework can create a lot of variants, but that give little value.
The prefork variant give a very high information, but any variant using prefork will have the same percentage gain. I think that the Json libs will be tested with prefork, but not with and without.
@TonyPythoneer @dcu @chunariov
Also about the scratch variant #5623, the results are the same, related to the issue #8209 to decide what we'll do.
Added "prefork" to the display name in some Go frameworks.