Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Framework]: Oxygen.jl #8789

Merged

Conversation

ndortega
Copy link
Contributor

@ndortega ndortega commented Mar 5, 2024

Hi there, I'm the author of the Oxygen.jl framework and this is my first attempt at registering the framework, please let me know if anything needs to be changed before this can be merged

@joanhey
Copy link
Contributor

joanhey commented Mar 22, 2024

@@ -0,0 +1,8 @@
FROM julia:latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you tie this down to a specific version please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NateBrady23
How specific are we talking? Would setting it to version 1 be specific enough or are you looking for an exact 1.x.x version?

Copy link
Member

@NateBrady23 NateBrady23 Mar 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If their version convention is such that breaking changes can be introduced in 1.x, then 1.x.x would be best, but really it's so that you can reproduce results on other hardware from the exact versions used in any of our runs.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interactive pools in 1.9 and scheduling in 1.10 will give vastly different results.

Copy link
Contributor Author

@ndortega ndortega Mar 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Julia is super good about backward compatibility, so setting to the latest stable version 1 should be fine.

Any breaking changes would get placed in version 2 of the language

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a compatibility issue. But 1.10 does different scheduling which brings different performance. It's not good enough yet, but it's significantly better (mainly because you can avoid being blocked from precompilation)

@pankgeorg
Copy link

@ndortega you can copy handlers from here if you'd like! I'd happily test Oxygen again! (last time I checked it didn't cut the speed, similarly to plain HTTP.jl)

@NateBrady23 NateBrady23 merged commit 158bd47 into TechEmpower:master Jul 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants