When invalidating the session make it possible to start using a new one #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix an issue where logout would correctly invalidate the session, but the Context.session remained the invalidated one so any subsequent changes to session values during that response would be lost. This change clears Context.session so a new session is created as needed and available for use during this response, instead of needing to wait for a subsequent request for the new session to be available.
msmith-techempower
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue where logout would correctly invalidate the session, but the Context.session remained the invalidated one so any subsequent changes to session values during that response would be lost. This change clears Context.session so a new session is created as needed and available for use during this response, instead of needing to wait for a subsequent request for the new session to be available.