Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Developer Experience]: Add Cypress tests for 'Contact Us' form #132

Open
chadstewart opened this issue May 11, 2023 · 5 comments · May be fixed by #148
Open

[Developer Experience]: Add Cypress tests for 'Contact Us' form #132

chadstewart opened this issue May 11, 2023 · 5 comments · May be fixed by #148
Assignees
Labels
developer experience Improves the experience of working on the project enhancement New feature or request

Comments

@chadstewart
Copy link
Collaborator

Developer Experience Issue

Please describe your Developer Experience Issue.
A clear and concise description of what the problem is. Ex. I have an issue when [...]

Add Cypress tests for 'Contact Us' form.

Describe the solution you'd like
A clear and concise description of what you want to happen. Add any considered drawbacks.

Add a Cypress Test suite that would:

  • Test if form would throw an error if not all inputs are filled in
  • Test if form will submit properly when all form elements are filled in
  • Test if an error message comes up under the appropriate form input if a change needs to be made

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

n/a

Teachability, Documentation, Adoption, Migration Strategy
If you can, explain how users will be able to use this and possibly write out a version in the docs.
Maybe a screenshot or design?

n/a

@chadstewart chadstewart added enhancement New feature or request developer experience Improves the experience of working on the project labels May 11, 2023
@Tausifqureshi786
Copy link

Hi is someone working on this issue?

@Tausifqureshi786
Copy link

@chadstewart If no one is working on this then can i please be assigned this issue?

@chadstewart
Copy link
Collaborator Author

Hey @Tausifqureshi786, sure, you can go ahead and take this issue.

Tausifqureshi786 added a commit to Tausifqureshi786/techishiring-website that referenced this issue May 25, 2023
Add test suite for contact us component for the given test cases in the issue TechIsHiring#132
@Tausifqureshi786 Tausifqureshi786 linked a pull request May 25, 2023 that will close this issue
@Tausifqureshi786
Copy link

Hello @chadstewart. I am just curious to know what would be the next step after submitting PR for this issue? Is someone reviewing it at the moment?

@chadstewart
Copy link
Collaborator Author

Hello @chadstewart. I am just curious to know what would be the next step after submitting PR for this issue? Is someone reviewing it at the moment?

My apologizes. I got distracted last week with a few things and I didn't get a chance to review the PR. I'm going to review it in a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer experience Improves the experience of working on the project enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants