implement home page #19
Conversation
✅ Deploy Preview for simple-shop-technullogy ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
![netlify[bot]](https://avatars.githubusercontent.com/in/13473?s=60&v=4){kind=small}
There was a problem hiding this comment.
Comment has been resolved by Amir hossein Hossein Zadeh Karimi
Amir hossein Hossein Zadeh Karimi left a comment:
Missing primary buttons background pattern.
Browser metadata
Path: /src/pages/home.html
Browser: Firefox 115.0 on Linux x86_64
Viewport: 1920 x 922 @1x
Language: en-US
Cookies: Enabled
There was a problem hiding this comment.
Good job @AmirHossein-z 👌
Honestly, I hadn't expected this result! It's amazing.
I reviewed your work and placed some comments. Please check and fix them.
Also, We can have even better result if you apply the following changes:
- Better structure for images in the
assetsdirectory. - Use kebab-case for file names.
- Use
pngformat for transparent files that don't need to change color or animate vector paths. It's much smaller thansvg.
Also, Please check & fix other comments.
tailwind.config.js
Outdated
| "light-purple": "#626E94", | ||
| "light-blue": "#00ADB5", | ||
| pink1: "#E11D48", | ||
| yellow1: "#FF9518", | ||
| blue1: "#050F2C", | ||
| grey1: "#f5f8fc", | ||
| grey2: "#DEE2EE", | ||
| grey3: "#D2D7E4", | ||
| grey4: "#BDC5DD", | ||
| grey5: "#7E8AAB", |
There was a problem hiding this comment.
Use this tool to name colors.
And, Be consistent. Use lower case or upper case which follows project guidelines.
tailwind.config.js
Outdated
| "shadow-1": "0px 24px 40px rgba(121, 127, 136, 0.05)", | ||
| "shadow-2": "0px 14px 24px 10px #7E8AAB1C", |
There was a problem hiding this comment.
- You can use unitless zero
- Be consistent, Use RGBA or HEX for color.
shadowrepeated in the class name. (.shadow-shadow-1)
src/pages/home.html
Outdated
| /> | ||
| </svg> | ||
| </a> | ||
| <a href="#" class="relative text-light-purple"> |
There was a problem hiding this comment.
Use #? instead # to prevent scroll to the top on click.
| <a href="#" class="relative text-light-purple"> | |
| <a href="#?" class="relative text-light-purple"> |
src/pages/home.html
Outdated
| <div class="flex flex-col justify-center gap-3"> | ||
| <img | ||
| src="/src/assets/images/get_shit_done.png" | ||
| alt="get shit done" | ||
| class="h-[323px] w-[316px]" | ||
| /> | ||
| <h5 class="text-base text-grey5">قاب عکس</h5> | ||
| <p class="text-[22px] font-bold text-blue1"> | ||
| قاب عکس شیب دار | ||
| </p> | ||
| <p class="mt-3 text-xl font-bold text-light-blue"> | ||
| ۲۴٬۰۰۰تومان- ۶۸٬۰۰۰ تومان | ||
| </p> | ||
| </div> |
There was a problem hiding this comment.
The whole item or only the image & title are expected as links.
Co-authored-by: Amirhossein Zareian <amirhossein.zareian.engineer@gmail.com>
|
I committed a change to the branch. Do not forget to pull changes. |
Signed-off-by: Amirhossein Zareian <amirhosseinzareian01@gmail.com>
Signed-off-by: Amirhossein Zareian <amirhosseinzareian01@gmail.com>
No description provided.