Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually link JWTDecode and SimpleKeychain #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

hoolrory
Copy link
Collaborator

@hoolrory hoolrory commented Sep 23, 2024

possible fix for us not using Carthage

image
  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

📋 Changes

📎 References

🎯 Testing

possible fix for us not using Carthage
@1419krusty
Copy link

should we push this to https://github.com/auth0/Auth0.swift instead of forking?

@Kevin-J-Harrison
Copy link

Is this related to the thing they are actively working on here auth0#870

@hoolrory
Copy link
Collaborator Author

@Kevin-J-Harrison doesn't look like the same thing. As far as I could tell our issue was that the dependency of Auth0 on JWTDecode only implicit in our build order, not explicit, so it was a race condition whether or not JWTDecode would be done building before Auth0 started

@hoolrory
Copy link
Collaborator Author

@1419krusty We could try, it seems to go against their preferred Carthage/Swift way of dependency management so I doubt they'd be too excited, and we'd probably have to make sure the iOS, tvOS, visionOS, watchOS targets worked with the same change.

Copy link

@LGriffioen LGriffioen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird that they didn't do this. seems like a lot of apps would have this problem. should we open a PR against the main repo?

@hoolrory
Copy link
Collaborator Author

hoolrory commented Sep 25, 2024

I've made a feature request and a PR in the Auth0.swift repo:
auth0#872
auth0#873

@Kevin-J-Harrison
Copy link

Nice!

Just for my curiosity, is there a reason we aren't using the swift package?

@LGriffioen
Copy link

yes, AppStore build configurations break swift packages because SPM expects debug or release only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants