-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manually link JWTDecode and SimpleKeychain #1
base: main
Are you sure you want to change the base?
Conversation
possible fix for us not using Carthage
should we push this to https://github.com/auth0/Auth0.swift instead of forking? |
Is this related to the thing they are actively working on here auth0#870 |
@Kevin-J-Harrison doesn't look like the same thing. As far as I could tell our issue was that the dependency of Auth0 on JWTDecode only implicit in our build order, not explicit, so it was a race condition whether or not JWTDecode would be done building before Auth0 started |
@1419krusty We could try, it seems to go against their preferred Carthage/Swift way of dependency management so I doubt they'd be too excited, and we'd probably have to make sure the iOS, tvOS, visionOS, watchOS targets worked with the same change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weird that they didn't do this. seems like a lot of apps would have this problem. should we open a PR against the main repo?
iOS, tvOS, watchOS, and visionOS
Nice! Just for my curiosity, is there a reason we aren't using the swift package? |
yes, AppStore build configurations break swift packages because SPM expects debug or release only |
possible fix for us not using Carthage
📋 Changes
📎 References
🎯 Testing