Fixing implicit instantiation errors with newer libc++ on macOS #1
+9
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BLesnau
force-pushed
the
fixImplicitInstantiationError
branch
from
915aa6c to
7ebe1dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/TechSmith/TSCLicensing/issues/1450
cpprestsdk started causing build failures with newer versions of libc++ on macOS. The errors looked like this
There was another PR to address this issue in the main cpprestsdk repo, but it may not be the best way to fix the problem. It also is unlikely to get merged any time soon.
microsoft#1820
We instead made our own fork of cpprestsdk (this repo) and are making our own change to fix the problem. The modified code is only used by cpprestsdk tests. I was unable to get cpprestsdk to build on its own, including its tests, so I have not been able to fix any new compilation issues that would come up there. Since we don't care about the tests at all, is it worth doing more work there to get it building?
More detail can be found in the PR that integrates these changes.
https://github.com/TechSmith/CommonCpp/pull/5836