Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor, optimise and simplify the Cheese API #12

Merged
merged 10 commits into from
Mar 28, 2024
Merged

Conversation

TechnicJelle
Copy link
Owner

@TechnicJelle TechnicJelle commented Mar 25, 2024

And the tests and benchmarks

TODO:

  • Rewrite the documentation
    • Code comments
    • Readme (put the Platter above the Single)
  • Fill out unit tests (check the //TODO)
  • Rewrite the benchmarks some more, to properly compare the same data between the Single and the Platter
  • Think about what to do with the performance reports on the website

@TechnicJelle TechnicJelle marked this pull request as draft March 25, 2024 03:37
Copy link
Contributor

@Chicken Chicken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk this algos just weird in my opinion the EnumMap usage in tracing and single cheese creation is unnecessary

src/main/java/com/technicjelle/Cheese.java Show resolved Hide resolved
@TechnicJelle TechnicJelle marked this pull request as ready for review March 28, 2024 00:02
@TechnicJelle TechnicJelle merged commit 46f626c into main Mar 28, 2024
2 checks passed
@TechnicJelle TechnicJelle deleted the feature/re-cheese branch March 28, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants