-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solves #22 #27
base: master
Are you sure you want to change the base?
Solves #22 #27
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, @spacemonkey1101 nice work, check my comments also please squash the commits
squash the commits |
Hey @spacemonkey1101 please add a screen shot and also squash your commits :) |
Yeah, you need to manage each color for dark mode and light mode, for now, you can just add a basic color and then send a PR and then, later on, send another PR for adding the new colors for dark and light mode. Also, I would suggest you add this switch thing or maybe a theme button on the top overflow menu(inside three dots). After a few days, we are going to add a Setting page then we will shift all these things there :) |
Solves #22
Sorry for making 2 commits. I actually forgot to fetch upstream.
Please tell me if the changes are ok