-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wgpu-rs and add Linux support #7
Conversation
…n). Done through direnv. We also don't need to center the cursor every frame if we're grabbing it properly.
…a different view projection correction per backend. Updated dependencies as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, many thanks for the update! I just tested on Windows with DX12 and it worked perfectly. There is still a small issue with gui rectangles on the bottom of the screen, but I will fix it when this is merged. If you are willing to make a small change or two we can merge this very soon!
Sorry for the delay, I am still very busy with my exams right now, I will resume development this summer.
@@ -0,0 +1,3 @@ | |||
window_size = [1600, 900] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be commited, and the very small render distance explains why only one chunk is displayed at the time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add this file to the .gitignore?
binding: 2, | ||
visibility: wgpu::ShaderStage::FRAGMENT, | ||
ty: wgpu::BindingType::SampledTexture { | ||
component_type: wgpu::TextureComponentType::Float, // TODO: This right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be Uint.
@@ -0,0 +1 @@ | |||
export RUST_LOG=voxel_rs_client=debug,voxel_rs_common=debug,voxel_rs_server=debug,wgpu_core=warn,gfx_backend_vulkan=warn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not fond of having this file in the tree, I think it should be removed. You can add it to the .gitignore though! When this is merged, I will add a note in the README.
Thanks a lot for the pull request, I will implement the changes myself! |
I'm quite interested in this project and have been considering doing something similar for a while now, so I figured I'd try and get it running on Linux and update all the dependencies while I'm at it. It's been a while since I've touched Rust, so please point out anything I've done incorrectly.
This pull request isn't done yet, however so far: