Project Happy Thoughts API - Kathinka #487
Conversation
kathinka
changed the title
There was a problem hiding this comment.
File names should be kebab-case (lowercase) if nothing else is specified 😇
There was a problem hiding this comment.
But nice idea breaking this out 👍
model/Happythoughts.js
Outdated
|
|
||
| const HappyThought = mongoose.model("HappyThought", happyThoughtSchema); | ||
|
|
||
| export default HappyThought; |
There was a problem hiding this comment.
It's good practice to always leave an empty line at the end of JS files
routes/Routes.js
Outdated
| @@ -0,0 +1,159 @@ | |||
| import express, { response } from "express"; | |||
There was a problem hiding this comment.
Why import { response } here? 👀
| .sort({ createdAt: "desc" }) | ||
| .limit(20) | ||
| .exec(); | ||
| res.json(happyThoughts); |
There was a problem hiding this comment.
A status code could be nice here
| const newHappyThought = await new HappyThought({ message }).save(); | ||
| res.status(201).json(newHappyThought); | ||
| } catch (error) { | ||
| console.error(error); // Log the error |
There was a problem hiding this comment.
Remove console.logs in production
| const updatedThought = await HappyThought.findByIdAndUpdate( | ||
| thoughtId, | ||
| { $inc: { hearts: 1 } }, | ||
| { new: true } | ||
| ); |
| { new: true } | ||
| ); | ||
| if (updatedThought) { | ||
| res.json(updatedThought); |
There was a problem hiding this comment.
Status code could be nice here too
| }); | ||
|
|
||
| //delete a happy thought | ||
| router.delete("/thoughts/:thoughtId", async (req, res) => { |
There was a problem hiding this comment.
Nice! Would be cool if it was reflected in your frontend as well, but since auth is not until this week, I understand you didn't want anyone to be able to delete anyone else's posts
| }); | ||
|
|
||
| //filter happy thoughts by limit or skip or both | ||
| router.get("/thoughts/q", async (req, res) => { |
There was a problem hiding this comment.
This doesn't need to be its own endpoint, you can include the query in your /thoughts endpoint
| }); | ||
|
|
||
| // get updated documentation | ||
| router.get("/", (req, res) => { |
There was a problem hiding this comment.
Most generic endpoints should always come first, e.g.
- /
- /books
- /books/:id
Netlify link
API
Site
Collaborators
solo