[217] Support UV /Poetry switch for maven plugin - InitializeHabushuMojo #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaebchoi
commented
Feb 13, 2025
| log.info("Validating UV-based project structure..."); | ||
| UVCommandHelper uvHelper = new UVCommandHelper(baseDir); | ||
| try { | ||
| uvHelper.execute(Arrays.asList("lock", "--check")); |
There was a problem hiding this comment.
I: Given that UV is immature than poetry, some of the commands are WIP,
They have uv check command WIP as seen here
jaebchoi
commented
Feb 13, 2025
| log.warn("Corrected - pyproject.toml and uv.lock now synced"); | ||
| } | ||
|
|
||
| String currentPythonPackageVersion = uvHelper.executeUVTool(Arrays.asList("--from=toml-cli", "toml", "get", "--toml-path=pyproject.toml", "project.version")); |
There was a problem hiding this comment.
I: Same as above, this is just workaround for now, once this issue is implement we can replace it for more readable command.
habushu-maven-plugin/src/main/java/org/technologybrewery/habushu/InitializeHabushuUV.java
Show resolved
Hide resolved
habushu-maven-plugin/src/main/java/org/technologybrewery/habushu/exec/UVCommandHelper.java
Outdated
Show resolved
Hide resolved
habushu-maven-plugin/src/main/java/org/technologybrewery/habushu/exec/UVCommandHelper.java
Outdated
Show resolved
Hide resolved
jaebchoi
force-pushed
the
217-uv-poetry-initializehabushumojo
branch
from
6f8a75f to
faf6f9d
Compare
woods-cpointe
approved these changes
Feb 14, 2025
habushu-maven-plugin/src/main/java/org/technologybrewery/habushu/exec/UVCommandHelper.java
Outdated
Show resolved
Hide resolved
jaebchoi
force-pushed
the
217-uv-poetry-initializehabushumojo
branch
from
faf6f9d to
c78be3d
Compare
meliz19
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #217