Skip to content

Conversation

@sarathlal-sarangadharan
Copy link
Contributor

@sarathlal-sarangadharan sarathlal-sarangadharan commented Aug 28, 2024

JIRA link

https://hee-tis.atlassian.net/browse/TD-4336

Description

Remove "Move" functionality from externally referenced catalogues

Screenshots

Primary catalogue:

image

Catalogue under which externally referenced.
image


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors
  • Written appropriate unit tests for the changes, including:
    • accessibility tests for new views
    • tests for new controller methods
    • tests for new or modified API endpoints
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

Copy link

@DRJTechnology DRJTechnology left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change implemented here prevents the Moving of resources where the default catalogue is not the current catalogue.
I don’t believe that this is the requirement.

I believe that, if any on the catalogue's content is referenced from external catalogues then no moving of resources should be permitted anywhere in the catalogue. Otherwise the ‘move resource here’ logic becomes very complex and difficult to explain to the user.

resources.[Resource] r ON nr.ResourceId = r.Id
INNER JOIN
resources.ResourceVersion rv ON rv.resourceId = nr.ResourceId
LEFT JOIN

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can not see any references to these joined tables:
resources.ResourceReference rr
resources.VideoResourceVersion vrv
resources.AudioResourceVersion arv
resources.ResourceVersionEvent rve
resources.ResourceVersion rvd

If they are not used they should be removed

ColinBeebyHEE pushed a commit that referenced this pull request Nov 11, 2024
…/TD-4336-mplement-Code-Changes-in-Web-UI-My-contributions-Page

TD-4336: Implement Code Changes in Web UI-My contributions Page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants