- 
                Notifications
    You must be signed in to change notification settings 
- Fork 1
TD-4336: Implement Code Changes in Web UI-My contributions Page #542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TD-4336: Implement Code Changes in Web UI-My contributions Page #542
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change implemented here prevents the Moving of resources where the default catalogue is not the current catalogue.
I don’t believe that this is the requirement.
I believe that, if any on the catalogue's content is referenced from external catalogues then no moving of resources should be permitted anywhere in the catalogue. Otherwise the ‘move resource here’ logic becomes very complex and difficult to explain to the user.
        
          
                .../LearningHub.Nhs.Database/Stored Procedures/Hierarchy/CheckCatalogueHasExternalReference.sql
          
            Show resolved
            Hide resolved
        
      …ce is added issue handled
| resources.[Resource] r ON nr.ResourceId = r.Id | ||
| INNER JOIN | ||
| resources.ResourceVersion rv ON rv.resourceId = nr.ResourceId | ||
| LEFT JOIN | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can not see any references to these joined tables:
resources.ResourceReference rr
resources.VideoResourceVersion vrv
resources.AudioResourceVersion arv
resources.ResourceVersionEvent rve
resources.ResourceVersion rvd
If they are not used they should be removed
…/TD-4336-mplement-Code-Changes-in-Web-UI-My-contributions-Page TD-4336: Implement Code Changes in Web UI-My contributions Page
JIRA link
https://hee-tis.atlassian.net/browse/TD-4336
Description
Remove "Move" functionality from externally referenced catalogues
Screenshots
Primary catalogue:
Catalogue under which externally referenced.

Developer checks
(Leave tasks unticked if they haven't been appropriate for your ticket.)
I have: