Skip to content

Conversation

frank-hee
Copy link

@frank-hee frank-hee commented Oct 17, 2025

JIRA link

TD-5808

Description

Added templates\core\context_header.mustache to theme
This overrides lib\templates\context_header.mustache from core code
New version does not have the following code in it's header thus removing all header icons:

{{#imagedata}}
<div class="page-header-image">
    {{{imagedata}}}
</div>
{{/imagedata}}

Screenshots

Before:
image

After:
image

image

Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors
  • Written appropriate unit tests for the changes
  • Manually tested my work with and without JavaScript
  • Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
  • Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

frank-hee and others added 30 commits March 11, 2025 16:54
…6-update-nhs-header

Feature/td 5276 update nhs header
Update api call to use Moodle theme base URL
…5-Display-SCORM-content-inline-with-full-screen-option

Feature/td 5575 display scorm content inline with full screen option
…_navbar_logo_link

Update logo link in header to point to main Learning Hub instance
…oter-links-dynamic

Update footer links to use base url from theme settings
…4-Add-Autosuggest-Functionality

Feature/td 5794 add autosuggest functionality
…5-Type-6-SCORM-sessions-losing-their-background-when-viewed-full-screen

Ensure SCORM content has background when full screen
…-adapt-exit-button-hiding

Feature/update adapt exit button hiding
paulstevendev and others added 25 commits September 16, 2025 16:14
…8-mobile-navigation-arrows-fix

add navigation theme files and styling
…1-Add-additional-theme-property-for-Admin-URL

Add and hook up Admin URL theme property
…4-expander-button-update

Update course section expander to nhsuk version
…5-focus-colour-fix

override boost focus styles with NHSUK styles
…7-Content-area-seems-narrow

Increase course page content area width
…9-Add-descriptions-for-Admin-URL-theme-properties

Feature/td 6289 add descriptions for admin url theme properties
…6-IOS-mobile-certificate-certified-users-table-issue

Resolve horizontal scrolling issue with table of certified users on mobile
…3-remove-unnecessary-course-navigation

remove surplus course navigation
…-Issue-logging-out-from-moodle-and-redirecting-to-live-url-when-try-to-search-with-any-search-term-on-moodle-screen

Update to use theme property to create correct search action URL
@frank-hee frank-hee self-assigned this Oct 17, 2025
@frank-hee frank-hee added the enhancement New feature or request label Oct 17, 2025
@frank-hee frank-hee closed this Oct 20, 2025
@frank-hee
Copy link
Author

frank-hee commented Oct 20, 2025

erroneous PR - closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants