This repository has been archived by the owner on Apr 13, 2020. It is now read-only.
[DCK] Remove secrets from scaffolding #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yajo
added a commit
to Tecnativa/doodba-qa
that referenced
this pull request
Feb 25, 2019
This new script creates the `.env` files required by the official scaffolding since Tecnativa/doodba-scaffolding#24. Files names are hardcoded now, some configuration support might be added in the future if somebody needs it. Default secret values match those in Doodba itself. It's added as a `before_script` in the Gitlab CI template, as very few jobs would work without it.
yajo
added a commit
to Tecnativa/doodba-qa
that referenced
this pull request
Feb 25, 2019
This new script creates the `.env` files required by the official scaffolding since Tecnativa/doodba-scaffolding#24. Files names are hardcoded now, some configuration support might be added in the future if somebody needs it. Default secret values match those in Doodba itself. It's added as a `before_script` in the Gitlab CI template, as very few jobs would work without it.
yajo
added a commit
to Tecnativa/doodba-qa
that referenced
this pull request
Feb 25, 2019
This new script creates the `.env` files required by the official scaffolding since Tecnativa/doodba-scaffolding#24. Files names are hardcoded now, some configuration support might be added in the future if somebody needs it. Default secret values match those in Doodba itself. It's added as a `before_script` in the Gitlab CI template, as very few jobs would work without it.
yajo
added a commit
to Tecnativa/doodba
that referenced
this pull request
Feb 25, 2019
- Document changes from Tecnativa/doodba-scaffolding#24. - Make tests compatible with Tecnativa/doodba-scaffolding#24 and Tecnativa/doodba-qa#13.
yajo
added a commit
to Tecnativa/doodba-qa
that referenced
this pull request
Feb 26, 2019
This new script creates the `.env` files required by the official scaffolding since Tecnativa/doodba-scaffolding#24. Files names are hardcoded now, some configuration support might be added in the future if somebody needs it. Default secret values match those in Doodba itself. It's added as a `before_script` in the Gitlab CI template, as very few jobs would work without it.
yajo
added a commit
to Tecnativa/doodba-qa
that referenced
this pull request
Feb 26, 2019
This new script creates the `.env` files required by the official scaffolding since Tecnativa/doodba-scaffolding#24. Files names are hardcoded now, some configuration support might be added in the future if somebody needs it. Default secret values match those in Doodba itself. It's added as a `before_script` in the Gitlab CI template, as very few jobs would work without it.
yajo
added a commit
to Tecnativa/doodba-qa
that referenced
this pull request
Feb 26, 2019
This new script creates the `.env` files required by the official scaffolding since Tecnativa/doodba-scaffolding#24. Files names are hardcoded now, some configuration support might be added in the future if somebody needs it. Default secret values match those in Doodba itself. It's added as a `before_script` in the Gitlab CI template, as very few jobs would work without it.
yajo
added a commit
to Tecnativa/doodba
that referenced
this pull request
Feb 26, 2019
- Document changes from Tecnativa/doodba-scaffolding#24. - Make tests compatible with Tecnativa/doodba-scaffolding#24 and Tecnativa/doodba-qa#13.
yajo
added a commit
to Tecnativa/doodba
that referenced
this pull request
Feb 26, 2019
- Document changes from Tecnativa/doodba-scaffolding#24. - Make tests compatible with Tecnativa/doodba-scaffolding#24 and Tecnativa/doodba-qa#13.
yajo
added a commit
to Tecnativa/doodba
that referenced
this pull request
Feb 26, 2019
- Document changes from Tecnativa/doodba-scaffolding#24. - Make tests compatible with Tecnativa/doodba-scaffolding#24 and Tecnativa/doodba-qa#13.
Git was never a good place to store secrets. With this change, you need to supply the secrets in separate, ignored files for test and prod environments.
yajo
added a commit
to Tecnativa/doodba
that referenced
this pull request
Mar 4, 2019
- Document changes from Tecnativa/doodba-scaffolding#24. - Make tests compatible with Tecnativa/doodba-scaffolding#24 and Tecnativa/doodba-qa#13.
yajo
added a commit
to Tecnativa/doodba
that referenced
this pull request
Mar 14, 2019
- Document changes from Tecnativa/doodba-scaffolding#24. - Make tests compatible with Tecnativa/doodba-scaffolding#24 and Tecnativa/doodba-qa#13.
yajo
added a commit
to Tecnativa/doodba
that referenced
this pull request
Mar 14, 2019
- Document changes from Tecnativa/doodba-scaffolding#24. - Remove scaffolding tests. Since Tecnativa/doodba-scaffolding#15, the scaffolding has its own tests, and these are very hard to maintain.
yajo
added a commit
to Tecnativa/doodba
that referenced
this pull request
Mar 14, 2019
- Document changes from Tecnativa/doodba-scaffolding#24. - Remove scaffolding tests. Since Tecnativa/doodba-scaffolding#15, the scaffolding has its own tests, and these are very hard to maintain.
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git was never a good place to store secrets.
With this change, you need to supply the secrets in separate, ignored files for test and prod environments.