Skip to content
This repository has been archived by the owner on Apr 13, 2020. It is now read-only.

[DCK] Remove builtin whitelist proxies from test #5

Merged
merged 2 commits into from
Aug 27, 2018
Merged

Conversation

yajo
Copy link
Contributor

@yajo yajo commented Aug 24, 2018

Apply Tecnativa/doodba#165 in scaffolding. See it for details.

@yajo yajo self-assigned this Aug 24, 2018
@yajo yajo added the enhancement New feature or request label Aug 24, 2018
@pedrobaeza
Copy link
Member

What happens if you don't create globalwhitelist_shared? Maybe should we have a global-scaffolding project too?

yajo added a commit to Tecnativa/doodba that referenced this pull request Aug 24, 2018
This change affects documentation only. To apply in your real world deployments:

- Merge Tecnativa/doodba-scaffolding#5 in your downstream scaffolding clone.
- Follow instructions added to README here.
yajo added a commit to Tecnativa/doodba that referenced this pull request Aug 24, 2018
This change affects documentation only. To apply in your real world deployments:

- Merge Tecnativa/doodba-scaffolding#5 in your downstream scaffolding clone.
- Follow instructions added to README here.
@yajo
Copy link
Contributor Author

yajo commented Aug 24, 2018

What happens if you don't create globalwhitelist_shared?

See Tecnativa/doodba#67 (comment)

Maybe should we have a global-scaffolding project too?

It would be good, although I'm more on the side of dropping some roles into https://galaxy.ansible.com/ to enable full server pool management.

In any case, it's not ready for disclosure.

@pedrobaeza
Copy link
Member

Well, I miss that also for SSL traefik proxy, so complete the system with the things you see more convenient (roles, scaffolding...).

@yajo
Copy link
Contributor Author

yajo commented Aug 24, 2018

I'll add that to my todo list.

@pedrobaeza
Copy link
Member

I'm thinking that we should leave one commented example in the scaffolding for easier reference when we need local whitelist. Do you agree?

@yajo
Copy link
Contributor Author

yajo commented Aug 24, 2018

I don't think so; devel.yaml still has whitelists, and in case you want to document things, the place to do so is the documentation, not the scaffolding, which is just a template. The docs are in https://github.com/Tecnativa/doodba#how-can-i-whitelist-a-service-and-allow-external-access-to-it and https://github.com/Tecnativa/docker-whitelist.

yajo added a commit to Tecnativa/doodba that referenced this pull request Aug 27, 2018
This change affects documentation only. To apply in your real world deployments:

- Merge Tecnativa/doodba-scaffolding#5 in your downstream scaffolding clone.
- Follow instructions added to README here.
@yajo yajo merged commit ea944f0 into master Aug 27, 2018
@yajo yajo deleted the globalwhitelist branch August 27, 2018 12:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants