-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for $AUTO_REQUIREMENTS
#175
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature was introduced in #71, but time has proven it buggy and not much useful. This feature has a chicken-and-egg problem in the devel environment: code doesn't exist at build time, but it is expected to be able to find the `requirements.txt` files inside it. It confuses the developer and creates divergencies between devel and test/prod environments (where that problem doesn't exist). Also it's breaking #174, which is a more important and actually used feature. The best fix is to drop support for this. If you really want to have requirements from remotes, you can add this to your `dependencies/pip.txt` file: ``` # Assuming you are installing all from server-tools -r https://raw.githubusercontent.com/OCA/server-tools/11.0/requirements.txt ``` It's a better choice because: - It's basic official pip. - It's explicit. - It works fine across environments.
zamberjo
added a commit
to aurestic/docker-odoo-base
that referenced
this pull request
May 2, 2022
zamberjo
added a commit
to aurestic/docker-odoo-base
that referenced
this pull request
Oct 14, 2022
zamberjo
added a commit
to aurestic/docker-odoo-base
that referenced
this pull request
Oct 14, 2022
zamberjo
added a commit
to aurestic/docker-odoo-base
that referenced
this pull request
Nov 8, 2022
zamberjo
added a commit
to aurestic/docker-odoo-base
that referenced
this pull request
Apr 5, 2023
zamberjo
added a commit
to aurestic/docker-odoo-base
that referenced
this pull request
Apr 25, 2023
zamberjo
added a commit
to aurestic/docker-odoo-base
that referenced
this pull request
Nov 10, 2023
zamberjo
added a commit
to aurestic/docker-odoo-base
that referenced
this pull request
Nov 15, 2023
zamberjo
added a commit
to aurestic/docker-odoo-base
that referenced
this pull request
Nov 15, 2023
zamberjo
added a commit
to aurestic/docker-odoo-base
that referenced
this pull request
Nov 17, 2023
zamberjo
added a commit
to aurestic/docker-odoo-base
that referenced
this pull request
Nov 19, 2023
zamberjo
added a commit
to aurestic/docker-odoo-base
that referenced
this pull request
Nov 21, 2023
zamberjo
added a commit
to aurestic/docker-odoo-base
that referenced
this pull request
Nov 22, 2023
zamberjo
added a commit
to aurestic/docker-odoo-base
that referenced
this pull request
Jan 18, 2024
zamberjo
added a commit
to aurestic/docker-odoo-base
that referenced
this pull request
May 8, 2024
zamberjo
added a commit
to aurestic/docker-odoo-base
that referenced
this pull request
Oct 4, 2024
zamberjo
added a commit
to aurestic/docker-odoo-base
that referenced
this pull request
Oct 7, 2024
zamberjo
added a commit
to aurestic/docker-odoo-base
that referenced
this pull request
Oct 10, 2024
zamberjo
added a commit
to aurestic/docker-odoo-base
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature was introduced in #71, but time has proven it buggy and not much useful.
This feature has a chicken-and-egg problem in the devel environment: code doesn't exist at build time, but it is expected to be able to find the
requirements.txt
files inside it.It confuses the developer and creates divergencies between devel and test/prod environments (where that problem doesn't exist).
Also it's breaking #174, which is a more important and actually used feature.
The best fix is to drop support for this. If you really want to have requirements from remotes, you can add this to your
dependencies/pip.txt
file:It's a better choice because: