Smarter, less strict, config generator #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
reviewed
Jul 8, 2019
yajo
force-pushed
the
config-generate-smarter
branch
4 times, most recently
from
00fd069
to
25e21c4
Compare
carlosdauden
approved these changes
Jul 11, 2019
yajo
force-pushed
the
config-generate-smarter
branch
from
25e21c4
to
6965ea9
Compare
Before Odoo v11, Odoo wasn't so strict when reading configuration. Since v11, where Python 3 started to be used, it used the new default `strict=True` mode to read configuration files. The strict mode forbids section and option repetitions. Although that seems legit for most apps (even Odoo itself), in Doodba we provide a set of predefined defaults that downstream scaffoldings should be able to override. To allow such behavior, now the script that generates the final config will do it in `strict=False` mode, but will remove duplicates and just use the latest option defined, effectively producing a strict config file out of a collection of non-strict configs. Of course, options until now are respected, like output of result while in `LOG_LEVEL=DEBUG` or env variable substitution. Full power! 💪
yajo
force-pushed
the
config-generate-smarter
branch
from
6965ea9
to
81503fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before Odoo v11, Odoo wasn't so strict when reading configuration. Since v11, where Python 3 started to be used, it used the new default
strict=Truemode to read configuration files.The strict mode forbids section and option repetitions. Although that seems legit for most apps (even Odoo itself), in Doodba we provide a set of predefined defaults that downstream scaffoldings should be able to override.
To allow such behavior, now the script that generates the final config will do it in
strict=Falsemode, but will remove duplicates and just use the latest option defined, effectively producing a strict config file out of a collection of non-strict configs.Of course, options until now are respected, like output of result while in
LOG_LEVEL=DEBUGor env variable substitution.Full power! 💪