Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document new RELAY_PASSWORD variable #272

Merged
merged 1 commit into from
Jan 2, 2020
Merged

Document new RELAY_PASSWORD variable #272

merged 1 commit into from
Jan 2, 2020

Conversation

yajo
Copy link
Contributor

@yajo yajo commented Dec 31, 2019

This breaking change will follow Tecnativa/doodba-scaffolding#56.

@Tecnativa TT20505

@yajo yajo self-assigned this Dec 31, 2019
@yajo
Copy link
Contributor Author

yajo commented Dec 31, 2019

@pedrobaeza I cannot do the variable translation we talked before. It'd have to be present in .env to be able to do that, but it's in another file because it's a secret.

@pedrobaeza
Copy link
Member

But can't you inject it in onbuild or similar in the compose file?

@yajo
Copy link
Contributor Author

yajo commented Dec 31, 2019

No way, sorry 😕

@pedrobaeza
Copy link
Member

pedrobaeza commented Dec 31, 2019 •
edited by yajo
Loading

Then please do:

  • Announce ASAP the breaking change in the issue.
  • Change our Ansible role to put both variables on each deployment.

@yajo yajo marked this pull request as ready for review January 2, 2020 13:32
@yajo yajo merged commit 4a5117b into master Jan 2, 2020
@yajo yajo deleted the document-smtp-env-password-change branch January 2, 2020 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yajo yajo

Labels
scaffolding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yajo @pedrobaeza