[FIX] 16/17: Proper ~root/.ssh pre-removal #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, thanks for the fix. Good point using a regexp for indicating the versions, but better to be explicit and as brackets are used for separators, it seems weird that way. Please rephrase it to |
manuel-florido
changed the title
manuel-florido
force-pushed
the
fix-private_repo_autoaggregate
branch
from
4b773ab
to
597b03e
Compare
|
Done 👌 Thank you! |
|
The explanation given in the first comment of the PR (which is pretty good) has not been put in the commit message. It's also better to use a neutral redaction avoiding first person. Something like: |
The symlink to /opt/odoo/custom/ssh is still being created as sub-directory (/root/.ssh/ssh), getting an error when trying to build the Doodba image. Docker uses '/bin/sh' as default shell and '[[ ]]' is a specific comparison construct of Bash. Removing the brackets, now the symlinks to /opt/odoo/custom/ssh are being successfully created.
manuel-florido
force-pushed
the
fix-private_repo_autoaggregate
branch
from
597b03e
to
9487571
Compare
|
Hello, Sorry I did not understand you at the first time. Now it is done 👍 . Thank you! |
pedrobaeza
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I found that the symlink to /opt/odoo/custom/ssh still being created as sub-directory (/root/.ssh/ssh) so I got an error when I tried to build my Odoo image.
Docker uses "/bin/sh" as default shell and "[[ ]]" is a specific comparison construct of Bash.
I remove the brackets and now the symlinks to /opt/odoo/custom/ssh is being created succesfully.
Issue origin: #585
@pedrobaeza