Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ascii/no-color progressbar #101

Closed
wants to merge 1 commit into from
Closed

Add ascii/no-color progressbar #101

wants to merge 1 commit into from

Conversation

ant31
Copy link

@ant31 ant31 commented Nov 24, 2016

Hi
I wanted a pytest-sugar without utf8 nor color, and the pytest --color=no was ignored by pytest-sugar. I ran into the same issue than #91
Even if themes can be created via the conf file, having an upstream one that match --color=no is usefull.

it looks like:

test_sugar.py sx...                    55% [=====   ]
test_sugar.py sx........s             100% [========]

Another thing added (that can be separated from this commit)
is the option --show-count to display the current tests-count/test-taken

 /test/test_api_usage.py ........................... 48% [=====     ][1072/2226]
                         ........................... 49% [=====     ][1099/2226]
                         ........................... 51% [======    ][1126/2226]
                         ........................... 52% [======    ][1153/2226]



@codecov-io
Copy link

codecov-io commented Nov 24, 2016

Current coverage is 67.58% (diff: 47.61%)

Merging #101 into master will decrease coverage by 0.83%

@@             master       #101   diff @@
==========================================
  Files             4          4          
  Lines           380        398    +18   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            260        269     +9   
- Misses          120        129     +9   
  Partials          0          0          

Powered by Codecov. Last update 306c61e...0b01777

@ant31 ant31 changed the title [WIP] Add ascii/no-color progressbar Add ascii/no-color progressbar Nov 25, 2016
@blueyed
Copy link
Collaborator

blueyed commented Dec 22, 2016

Please rebase it on master, which uses pytest 3.0 now.

@ant31
Copy link
Author

ant31 commented Dec 22, 2016

it's rebased

pytest_sugar.py Outdated
@@ -28,13 +28,14 @@
from _pytest.terminal import TerminalReporter


__version__ = '0.7.1'
__version__ = '0.7.2'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I remove this version bump?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it looks like you add it (and shouldn't) - master is at 0.7.1..

@ant31
Copy link
Author

ant31 commented Dec 23, 2016

@blueyed I removed the version change. it should be good now

@Teemu
Copy link
Owner

Teemu commented Dec 24, 2016

Thank you for your contribution.

However, at this point I am focusing on:

  1. improving code quality (the current code base is frankly a mess. It is not surprising since this project started as a hack and pytest code is frankly quite hard to understand)
  2. improving our test coverage (how ironic for py.test plugin)
  3. making things work (lots of issues!)

so this PR shall wait until then.

@ant31
Copy link
Author

ant31 commented Oct 23, 2017

@Frozenball / @blueyed I would expect small project to be more open to contribution, especially when issue/feature request have been reported several times.

I close this, I'm good with using my fork.
thanks

@ant31 ant31 closed this Oct 23, 2017
@blueyed
Copy link
Collaborator

blueyed commented Oct 23, 2017

@ant31
No need to close it out of frustration.

btw: I am a contributor only myself.

@Teemu
Copy link
Owner

Teemu commented Oct 23, 2017 via email

@blueyed
Copy link
Collaborator

blueyed commented Oct 23, 2017

I understand.
But still leave if open for others to pick it up, and maintainers to merge it eventually.

Are you trying to get PR zero? For me https://github.com/pulls shows 208 open PRs currently, but you do not have to check that page.
Let it rot and getting some attention even after years I would say.
It's different from maintainers wanting to get the queue down, where I can understand it better to close PRs.

Anyway, let's not waste our precious time in this discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants