-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ascii/no-color progressbar #101
Conversation
Current coverage is 67.58% (diff: 47.61%)@@ master #101 diff @@
==========================================
Files 4 4
Lines 380 398 +18
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 260 269 +9
- Misses 120 129 +9
Partials 0 0
|
Please rebase it on master, which uses pytest 3.0 now. |
it's rebased |
pytest_sugar.py
Outdated
@@ -28,13 +28,14 @@ | |||
from _pytest.terminal import TerminalReporter | |||
|
|||
|
|||
__version__ = '0.7.1' | |||
__version__ = '0.7.2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do I remove this version bump?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it looks like you add it (and shouldn't) - master is at 0.7.1
..
@blueyed I removed the version change. it should be good now |
Thank you for your contribution. However, at this point I am focusing on:
so this PR shall wait until then. |
@Frozenball / @blueyed I would expect small project to be more open to contribution, especially when issue/feature request have been reported several times. I close this, I'm good with using my fork. |
@ant31 btw: I am a contributor only myself. |
I am sorry if you feel ignored. I have very little time for personal
projects nowadays and I don't like to spend that little time with stuff
that doesn't bring joy to me. Maintaining code, checking pull requests and
doing releases is work and is not as simple as pressing a button if you
want to do it right.
If your fork works, great! Pytest API has been pretty stable for a long
time so there really isn't any urgency to get it upstream I think.
On Oct 23, 2017 14:31, "Daniel Hahler" <notifications@github.com> wrote:
@ant31 <https://github.com/ant31>
No need to close it out of frustration.
btw: I am a contributor only myself.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#101 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADQMmnzMW-WoD-X-GU642IhKZpC4sRQks5svHkVgaJpZM4K8Ak0>
.
|
I understand. Are you trying to get PR zero? For me https://github.com/pulls shows 208 open PRs currently, but you do not have to check that page. Anyway, let's not waste our precious time in this discussion. |
Hi
I wanted a pytest-sugar without utf8 nor color, and the pytest
--color=no
was ignored by pytest-sugar. I ran into the same issue than #91Even if themes can be created via the conf file, having an upstream one that match
--color=no
is usefull.it looks like:
Another thing added (that can be separated from this commit)
is the option
--show-count
to display the currenttests-count/test-taken