Update so many dependencies #141
Conversation
.travis.yml
Outdated
| - "6" | ||
| - "8" | ||
| - "12" | ||
| - "14" |
There was a problem hiding this comment.
Does this mean it's a breaking change since it no longer runs the tests on node 6?
(Or is it running the tests on the source code, and the built library runs fine on the same browser/node versions?)
There was a problem hiding this comment.
Some updates to Rollup and Rollup plugins use async which wasn't available in Node 6, so the actual build fails.
| @@ -24,27 +24,26 @@ | |||
| "homepage": "https://github.com/TehShrike/abstract-state-router", | |||
| "dependencies": { | |||
| "combine-arrays": "~1.0.2", | |||
| "eventemitter3": "2.0.3", | |||
| "hash-brown-router": "3.4.0", | |||
| "eventemitter3": "4.0.7", | |||
There was a problem hiding this comment.
https://github.com/primus/eventemitter3/releases/tag/3.0.0
The differences seem pretty minor, but we do expose some emitters as part of the API. The exact emitter methods were not documented in our readme, so I'm not sure if this would be a breaking change or not.
There was a problem hiding this comment.
Oh yeah, I remember seeing that discussion in a different pull request a while back. I guess since we don't document them, it wouldn't be considered breaking?
|
huh... those Babel helpers do make me nervous... if |
|
Just bumped those dependency versions again, since it's been a while. Nothing major to report, just the ones original to the pull request. |
notes.txt
A few things to mention:
update deps
I updated all the dependencies, and then made sure that
npm run testandnpm run test:browserworked. Then I also temporarily changed the tests so that they would fail, and reran them to make sure that they actually failed. Always a little nervous about major version bumps...normalize to
~The libs that were yours, I normalized the
package.jsonto use~on the version number. It wasn't consistent, and I know it doesn't matter in this case but it was bugging me. 😅babel
The babel update is kind of big: they did away with
babel-preset-*in favor of@babel/preset-envwhich uses some defaults for what browser versions etc it transpiles/polyfills for. They suggest adding a config to make presets explicit, but otherwise it looks like the defaults are appropriate. Also they deprecatedbabel-helpers. Neat.rollup
With the new Rollup config, one thing I'm still unclear on is what the
externaloption means...My understanding is that
external(now at least) means Rollup won't put those libs in to the final bundle. But that doesn't seem quite right: the Electron/browser tests pass withexternalstill set, and I don't think it can resolve them otherwise, so honestly I'm not sure how all the tests pass?(Note: if I drop the
externalfrom the Rollup config, all tests still pass, but the bundle size is ~2x bytes.)