Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: helpful error message when child DOM not found #148

Merged

Conversation

saibotsivad
Copy link
Collaborator

@saibotsivad saibotsivad commented Jan 21, 2022

If you forget to put a child node in, for example in Svelte it would be forgetting to put the uiView element, the error that gets thrown is rather cryptic.

The exact error depends on the renderer exactly, but for example in Svelte it looks like this:
image

Instead of throwing a cryptic error, we can reject with an error that gets bubbled out to stateChangeError.

@saibotsivad saibotsivad force-pushed the feature/helpful-error-message branch 2 times, most recently from 1f21097 to cd6ab2d Compare January 21, 2022 20:53
@TehShrike TehShrike merged commit 831e747 into TehShrike:master Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants