Support passing an allowStateChange function that is evaluated befo…
#154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re a state change The URL will have already changed at this point, but since `allowStateChange` is evaluated before the state change has started, we can just set the URL back to what it was before without reloading any states.
Apparently this could fail before.
|
What ECMA version are we targeting? |
looks like I gave myself some cover in the docs by saying "modern JS syntax". I think nowadays I'd define that as "in major browsers for around 2 years". I assume anyone targeting environments older than that is running babel anyways. |
TehShrike
reviewed
Jun 9, 2023
I added this just so I could test the route guards, but it could come in handy later.
- allowStateChange = false prevents state change (does not start state change, resolve unreachable state, or destroy context of guarded state) - allowStateChange = true does not prevent state change - allowStateChange can access domApi Some of the other examples used the hashRouter as well but I haven't figured out how to write these tests using that, so I'll do that after the weekend
Make sure it only gets called once when we're getting sent to a child case
Only run the route guards if the last completely loaded state and the last state to start activating are the same. This will prevent the route guard from getting tripped again upon a redirect in the destination state.
TehShrike
reviewed
Jun 14, 2023
Co-authored-by: Josh Duff <me@JoshDuff.com>
- canLeaveState instead of allowStateChange - Check parameters as well as state names in a couple spots - Only pass the destination name string, not a state object to allowStateChangeOrRevert - Array destructuring instead of concat + optional chain + nullish coalescing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…re a state change
The URL will have already changed at this point, but since
allowStateChangeis evaluated before the state change has started, we can just set the URL back to what it was before without reloading any states.