Avoid mutating options #173
Merged
+18
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
RebeccaStevens
pushed a commit
to RebeccaStevens/fork-deepmerge
that referenced
this pull request
Nov 17, 2020
RebeccaStevens
pushed a commit
to RebeccaStevens/fork-deepmerge
that referenced
this pull request
Nov 17, 2020
RebeccaStevens
pushed a commit
to RebeccaStevens/fork-deepmerge
that referenced
this pull request
Nov 17, 2020
RebeccaStevens
pushed a commit
to RebeccaStevens/fork-deepmerge
that referenced
this pull request
Nov 18, 2020
RebeccaStevens
pushed a commit
to RebeccaStevens/fork-deepmerge
that referenced
this pull request
Nov 19, 2020
RebeccaStevens
pushed a commit
to RebeccaStevens/fork-deepmerge
that referenced
this pull request
Nov 19, 2020
RebeccaStevens
pushed a commit
to RebeccaStevens/fork-deepmerge
that referenced
this pull request
Nov 19, 2020
RebeccaStevens
pushed a commit
to RebeccaStevens/fork-deepmerge
that referenced
this pull request
Nov 19, 2020
RebeccaStevens
pushed a commit
to RebeccaStevens/fork-deepmerge
that referenced
this pull request
Nov 20, 2020
RebeccaStevens
pushed a commit
to RebeccaStevens/fork-deepmerge
that referenced
this pull request
Nov 27, 2020
RebeccaStevens
pushed a commit
to RebeccaStevens/fork-deepmerge
that referenced
this pull request
Nov 27, 2020
RebeccaStevens
pushed a commit
to RebeccaStevens/fork-deepmerge
that referenced
this pull request
Nov 27, 2020
|
I decided to just put this fix back into the v5 release instead of pushing a v4 patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#167 (Stops mutating options object) was reverted due to #171 (IE 11 regression).
I re-implemented the functionality without using Object.assign.