chore: Modernize repo and code #26
Open
+12,224
−982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…li utility and refactor repo stuff
rpstid
reviewed
Feb 26, 2025
.github/workflows/latch_sdk_python_manual_increase_version.yaml
Outdated
Show resolved
Hide resolved
src/latch_sdk/response.py
Outdated
| """ | ||
|
|
||
| def __init__(self, data: "str | dict[str, Any]"): | ||
| """ |
There was a problem hiding this comment.
One line comment instead of three lines?
There was a problem hiding this comment.
Are you talking about docstring?
rpstid
reviewed
Feb 26, 2025
rpstid
reviewed
Feb 26, 2025
rpstid
reviewed
Feb 27, 2025
src/latch_sdk/sansio.py
Outdated
| params = {"wallet": web3_account, "signature": web3_signature} | ||
| return self._prepare_http("POST", path, None, params) | ||
|
|
||
| def pair( |
There was a problem hiding this comment.
Separaría los métodos que se ofrecen de interfaz a los desarrolladores a su propio fichero:
pair, unpair, status, operation_status...
There was a problem hiding this comment.
No entiendo que quieres decir. ¿Cada operación en su propio fichero? ¿o un fichero por conjunto de operaciones?
|
Añadiría en cada fichero de código comentarios sobre la funcionalidad que implementan para hacer la vida más sencilla a futuros mantenedores |
…r and location verification on status operation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What is the goal?
📝 Notes
It changes the exposed API using
LatchSDKclasses, but you could use theLatchclasses in order to get an API similar the old one.✅ Checklist