Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS-10813 Make Forms component in SwiftUI #419

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

alejandroruizponce
Copy link
Contributor

@alejandroruizponce alejandroruizponce commented Dec 5, 2024

🎟️ Jira ticket

https://jira.tid.es/browse/IOS-10813

πŸ₯… What's the goal?

As a performance objective to make SwiftUI components, Forms component will be migrated from UIKit to SwiftUI.

🚧 How do we do it?

A new component similar to the component in UIKit has been created and added inside the Catalog.

Figma specs: https://www.figma.com/design/e8d3PkXitUJ1Jwgc9Y3mNc/%F0%9F%94%B8-Input-Fields-%26-Forms-Component-Specs?node-id=2602-5127&node-type=frame&t=Kv0YhinRfGQnva8S-0

πŸ§ͺ How can I verify this?

(New) SwiftUI (Old) UIKit
Β Screenshot 2023-10-03 at 15 27 29Β  Screenshot 2023-10-03 at 15 30 48

πŸ‘ AppCenter build

Screenshot 2024-12-05 at 18 07 16

@alejandroruizponce alejandroruizponce requested review from a team, idenjoe, dhidalgofadrique and aweell and removed request for a team December 5, 2024 17:03
// String+Utils.swift
// String+InputField.swift
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well seen πŸ•΅οΈ

Copy link
Contributor

@dhidalgofadrique dhidalgofadrique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!!!

@alejandroruizponce alejandroruizponce merged commit 3769e2c into main Dec 16, 2024
1 check passed
@alejandroruizponce alejandroruizponce deleted the IOS-10813-Migrate-Forms-to-SwiftUI branch December 16, 2024 10:22
@tuentisre
Copy link
Collaborator

πŸŽ‰ This PR is included in version 33.6.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants