Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error CS8363 A default literal 'default' is not valid as a pattern #631

Closed
wants to merge 1 commit into from
Closed

Fix error CS8363 A default literal 'default' is not valid as a pattern #631

wants to merge 1 commit into from

Conversation

karb0f0s
Copy link
Member

@karb0f0s karb0f0s commented Mar 6, 2018

@karb0f0s karb0f0s closed this Mar 9, 2018
@poulad
Copy link
Member

poulad commented Mar 9, 2018

You closed it. Is the issue resolved?

@karb0f0s
Copy link
Member Author

karb0f0s commented Mar 9, 2018 •
edited
Loading

@tuscen said it's better to create PRs to devel branch. I'll make new PR to dev a bit later, or I could reopen this PR. @tuscen also suggested to use == null instead of string.IsNullOrEmpty. What is the best approach: == null, is null or string.IsNullOrEmpty?

@karb0f0s karb0f0s deleted the fix_disalow_default branch March 10, 2018 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karb0f0s @poulad