Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access to DefaultSignalPayload #115

Closed
nevillco opened this issue Sep 5, 2023 · 3 comments
Closed

Access to DefaultSignalPayload #115

nevillco opened this issue Sep 5, 2023 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@nevillco
Copy link
Contributor

nevillco commented Sep 5, 2023

I am trying out a project that uses TelemetryDeck analytics on iOS via this SDK and on the backend via Vapor. It's working well and the combination of frontend/backend events allows for some clear insights/funnel analysis.

This SDK sends a number of default properties including appVersion, buildNumber, isTestFlight, isAppStore etc. via the DefaultSignalPayload. Several of these signals would be useful to pass to my backend events, but that's not currently possible because the associated values are internal. I would like to expose them to clients, but thought I'd start with an issue before a PR just because I'm not sure if it's something the maintainers want. Happy to raise a PR if it is.

@winsmith winsmith added enhancement New feature or request help wanted Extra attention is needed labels Oct 4, 2023
@winsmith
Copy link
Contributor

Oh yes please create a PR! Thank you :)

BTW you might also consider checking out the dedicated Vapor SDK: https://github.com/getsidetrack/vapor-telemetrydeck

@nevillco
Copy link
Contributor Author

Yep, I am using that on the backend, and it works great! I'd just like to have its events also contain a appVersion, buildVersion, isAppStore etc. like the client events do, hence this feature request. PR here.

@winsmith
Copy link
Contributor

Fixed by #126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants