Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose WayID in Annotation Object of RouteResponse #200

Closed
wangyoucao577 opened this issue Mar 6, 2020 · 1 comment
Closed

Expose WayID in Annotation Object of RouteResponse #200

wangyoucao577 opened this issue Mar 6, 2020 · 1 comment
Labels
Ideas Ideas for long-term discussion NewFeature New feature or feature improvement Prototype Proof of concept

Comments

@wangyoucao577
Copy link

We can get some contents in the Annotation object by add parameter &annotations=true when we request a route.
In the Alternatives Ranking, we're using nodes from annotation object to match traffic data. But it's not very easy to use since our traffic data indexed by wayID instead of nodes. Also, most of our other services are heavily based on wayID, so if we can add wayID in annotation object will be very helpful.

Two proposals:

  1. Use an new microservice to do it between osrm-ranking and osrm-backend.
    • The new microservice will have to load wayID->nodes mapping and indexed by nodes to unpack the wayIDs.
    • Disadvantage: maybe possible to cost too much memory(not sure whether 64GB is enough for NA or not).
    • Advantage: easy to implement since don't need to change the C++ flow.
  2. Support it in C++ implementation directly.
    • It may not that easy to implement, need to do some research & estimation.

I think we may go with proposal-1 at present. @CodeBear801 How's your idea?

@wangyoucao577 wangyoucao577 added the Ideas Ideas for long-term discussion label Mar 6, 2020
@wangyoucao577 wangyoucao577 added NewFeature New feature or feature improvement Prototype Proof of concept labels Nov 9, 2020
@wangyoucao577
Copy link
Author

Has been done by #296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ideas Ideas for long-term discussion NewFeature New feature or feature improvement Prototype Proof of concept
Projects
None yet
Development

No branches or pull requests

1 participant