Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Annotation/ways #296

Merged
merged 8 commits into from
Apr 23, 2020
Merged

Expose Annotation/ways #296

merged 8 commits into from
Apr 23, 2020

Conversation

wangyoucao577
Copy link

@wangyoucao577 wangyoucao577 commented Apr 22, 2020

Issue

Description

A summary description for what the PR achieves.

  • Annotation/Nodes compatible with both int64 array and string array incoming;
  • Add Ways in Annotation of OSRM API;
  • Load and monitor nodes2way.db in osrm-ranking;
  • Retrieve annotation/ways from annotation/nodes when recieved OSRM route response;

Be aware that you may still see invalid nodeIDs(similar with #276) after osrm-ranking. It's limited by Javascript/JSON parsing(see more in https://github.com/callumlocke/json-formatter#why-are-large-numbers-not-displayed-accurately). Simply disable your brower extension's automatically parsing, you'll see correct values.

Tasklist

Prerequirements

  • Want to contribute? Great! First, please read this page Contribution Guidelines.
  • If your PR is still work in progress please attach the relevant label.

@wangyoucao577 wangyoucao577 self-assigned this Apr 22, 2020
@wangyoucao577 wangyoucao577 added the NewFeature New feature or feature improvement label Apr 22, 2020
@wangyoucao577 wangyoucao577 added this to the Sprint 62(Dev:05/12) milestone Apr 22, 2020
@wangyoucao577 wangyoucao577 added the Prototype Proof of concept label Apr 22, 2020
@wangyoucao577 wangyoucao577 merged commit 8d4d5bc into master Apr 23, 2020
@wangyoucao577 wangyoucao577 deleted the feature/expose-ways branch April 23, 2020 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NewFeature New feature or feature improvement Prototype Proof of concept
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose wayID in osrm route response by post processing
2 participants