Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul: Qemu Guest Agent #327

Merged
merged 4 commits into from
Apr 18, 2024
Merged

Conversation

Tinyblargon
Copy link
Collaborator

Fixes #323

Re-implements the QemuGuestAgent as the current version of proxmox has more options than disable and enable:

type QemuGuestAgent struct {
	Enable *bool               `json:"enable,omitempty"` // Optional
	Type   *QemuGuestAgentType `json:"type,omitempty"`   // Optional
	Freeze *bool               `json:"freeze,omitempty"` // Optional
	FsTrim *bool               `json:"trim,omitempty"`   // Optional
}

I'll fix this downstream in the Terraform provider as well.

@Tinyblargon Tinyblargon added type/bug type/enhancement An improvement of existing functionality labels Apr 15, 2024
@Tinyblargon Tinyblargon requested a review from mleone87 April 15, 2024 11:59
@Tinyblargon Tinyblargon self-assigned this Apr 15, 2024
@Tinyblargon Tinyblargon merged commit 5a3afe8 into Telmate:master Apr 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Unable to disable qemu-guest-agent.
1 participant