feat: client intialized with ticket and CSRF prevention Token #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Tinyblargon any chance for a review and merge for this tiny PR? |
Tinyblargon
requested changes
Nov 23, 2024
| @@ -131,6 +131,10 @@ func (c *Client) SetAPIToken(userID, token string) { | |||
| c.session.SetAPIToken(userID, token) | |||
| } | |||
|
|
|||
| func (c *Client) SetTicket(ticket, csrfPreventionToken string) { | |||
There was a problem hiding this comment.
Could you add a comment to this?
Just a notice that it is different from the normal login/api authentication methods and what it is used for.
proxmox/session.go
Outdated
| @@ -167,6 +167,11 @@ func (s *Session) SetAPIToken(userID, token string) { | |||
| s.AuthToken = auth | |||
| } | |||
|
|
|||
| func (s *Session) SetTicket(ticket, csrfPreventionToken string) { | |||
There was a problem hiding this comment.
Can you make this private so setTicket? Nothing in Session should be exposed.
There was a problem hiding this comment.
func (Session)setTicket made private
|
Thanx @Tinyblargon |
This was referenced Nov 24, 2024
Tinyblargon
added
type/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client intialized with ticket and CSRF prevention Token.
Completes #370