Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize #374

Merged
merged 12 commits into from
Nov 9, 2024
Merged

Optimize #374

merged 12 commits into from
Nov 9, 2024

Conversation

Tinyblargon
Copy link
Collaborator

@Tinyblargon Tinyblargon commented Nov 9, 2024 •
edited
Loading

  • Added to the style guide.
  • Optimized the internals of QemuUSB.
  • Removed dead code.
  • Reworked GroupName.Validate() to have it's errors as constants.
  • Changed pointer to value, as the pointer only added the need for more validation.

@Tinyblargon Tinyblargon added the type/refactoring Existing code has been cleaned up. There should be no new functionality label Nov 9, 2024
@Tinyblargon Tinyblargon self-assigned this Nov 9, 2024
@Tinyblargon Tinyblargon marked this pull request as ready for review November 9, 2024 12:05
@Tinyblargon Tinyblargon changed the title Optimize1 Optimize Nov 9, 2024
@Tinyblargon Tinyblargon merged commit 0146e30 into Telmate:master Nov 9, 2024
5 checks passed
@Tinyblargon Tinyblargon added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Tinyblargon Tinyblargon

Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files type/refactoring Existing code has been cleaned up. There should be no new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Tinyblargon