Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Session model specs #185

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Add Session model specs #185

merged 3 commits into from
Oct 2, 2024

Conversation

andresag4
Copy link
Collaborator

Description

Please include a summary of the change. Also, include any additional information that you think is important for reviewers to know. Link to a related issue if applicable.

How has this been tested?

Please mark the tests that you ran to verify your changes. If difficult to test, consider providing instructions so reviewers can test.

  • Manual testing
  • System tests
  • Unit tests
  • None

Checklist

  • CI pipeline is passing
  • My code follows the conventions of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • I have added seed data to the database (if applicable)

Release tasks

Add any tasks that need to be done before/after the release of this feature.

Screenshots/Loom

This section is relevant in case we want to share progress with the team, otherwise, it can be omitted.

@andresag4 andresag4 marked this pull request as ready for review September 19, 2024 17:38
@@ -39,4 +46,51 @@
expect(session).not_to be_valid
end
end

describe "#live?" do
it { expect(live_session).to be_live }
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this allow us to check that the factory is creating the resource correctly

@Sergio-e Sergio-e merged commit cc7ef8e into main Oct 2, 2024
4 checks passed
@Sergio-e Sergio-e deleted the session-specs branch October 2, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants