Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing type for useTheme, and Example #6

Closed
wants to merge 6 commits into from
Closed

Add missing type for useTheme, and Example #6

wants to merge 6 commits into from

Conversation

csantos1113
Copy link
Contributor

This PR complements commit c427aed and fixes #2

  • Add missing type for useTheme
  • Add example for how to use this hook
const UseThemeExample = () => {
  const theme = useTheme();
  return <ActivityIndicator size="small" color={theme.colors?.blue100} />;
};
  • Organize Example layout

image

image

@csantos-nydig csantos-nydig mentioned this pull request Aug 4, 2021
Closed
@csantos1113 csantos1113 mentioned this pull request Aug 4, 2021
Merged
finkef
finkef reviewed Aug 5, 2021
View reviewed changes
src/types/core.d.ts Outdated Show resolved Hide resolved
csantos1113 and others added 2 commits August 5, 2021 12:12
@csantos1113 @finkef
Update src/types/core.d.ts
749dc8a 
Co-authored-by: Fabian Finke <f.finke97@icloud.com>
@csantos1113
Remove optional check
b5263bc
@csantos1113
Copy link
Contributor Author

@Temzasse pls feel to merge it whenever if you agree with the change. Thanks!

csantos1113 added a commit to csantos1113/stitches-native that referenced this pull request Aug 5, 2021
@csantos1113
Take out Temzasse#6 code
d7197b2
csantos1113 added a commit to csantos1113/stitches-native that referenced this pull request Aug 5, 2021
@csantos1113
Take out Temzasse#6 code
bb37b6e
@csantos1113
Copy link
Contributor Author

Closing this PR for now. Will re-open a new one once #8 is merged

@csantos1113 csantos1113 closed this Aug 5, 2021
Temzasse pushed a commit that referenced this pull request Aug 5, 2021
@csantos1113 @csantos-nydig @finkef
Token usages from within utils (#8)
97042f7 
* Add missing type for useTheme, and Example

* Add new line

* Clean up code

* run lint

* Support theme tokens from within utils fn

* Update src/types/core.d.ts

Co-authored-by: Fabian Finke <f.finke97@icloud.com>

* Remove optional check

* Take out #6 code

* Take out #6 code

Co-authored-by: Cesar Santos <cesar.santos@nydig.com>
Co-authored-by: Fabian Finke <f.finke97@icloud.com>
@Temzasse Temzasse mentioned this pull request Aug 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finkef finkef finkef left review comments

@Temzasse Temzasse Temzasse left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dynamic styles based on user interaction
4 participants
@csantos1113 @Temzasse @finkef @csantos-nydig