fix(ios): fix HippyDisplayLink leak

Tencent · Dec 22, 2023 · 0807923 · 0807923
1 parent 051da17
commit 0807923
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/framework/ios/base/HippyDisplayLink.m b/framework/ios/base/HippyDisplayLink.m
@@ -23,12 +23,13 @@
 #import "HippyDisplayLink.h"
 
 #import <Foundation/Foundation.h>
-#import <QuartzCore/CADisplayLink.h>
+#import <QuartzCore/QuartzCore.h>
 
 #import "HippyAssert.h"
 #import "HippyBridgeModule.h"
 #import "HippyFrameUpdate.h"
 #import "HippyModuleData.h"
+#import "HippyWeakProxy.h"
 
 #define HippyAssertRunLoop() HippyAssert(_runLoop == [NSRunLoop currentRunLoop], @"This method must be called on the CADisplayLink run loop")
 
@@ -41,7 +42,8 @@ @implementation HippyDisplayLink {
 - (instancetype)init {
     if ((self = [super init])) {
         _frameUpdateObservers = [NSMutableSet new];
-        _jsDisplayLink = [CADisplayLink displayLinkWithTarget:self selector:@selector(_jsThreadUpdate:)];
+        HippyWeakProxy *weakProxy = [HippyWeakProxy weakProxyForObject:self];
+        _jsDisplayLink = [CADisplayLink displayLinkWithTarget:weakProxy selector:@selector(_jsThreadUpdate:)];
     }
 
     return self;