fix(android): memory leak of RecyclerViewEventHelper

Tencent · Apr 24, 2023 · 144524f · 144524f
1 parent 1f4abfd
commit 144524f
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/android/sdk/src/main/java/com/tencent/mtt/hippy/views/hippylist/RecyclerViewEventHelper.java b/android/sdk/src/main/java/com/tencent/mtt/hippy/views/hippylist/RecyclerViewEventHelper.java
@@ -260,8 +260,10 @@ public void sendOnScrollEvent() {
     }
 
     private void observePreDraw() {
-        if (!isInitialListReadyNotified && viewTreeObserver == null) {
-            viewTreeObserver = hippyRecyclerView.getViewTreeObserver();
+        if (!isInitialListReadyNotified) {
+            if (viewTreeObserver == null) {
+                viewTreeObserver = hippyRecyclerView.getViewTreeObserver();
+            }
             viewTreeObserver.addOnPreDrawListener(preDrawListener);
         }
     }
@@ -396,7 +398,9 @@ public void onViewAttachedToWindow(View v) {
 
     @Override
     public void onViewDetachedFromWindow(View v) {
-
+        if (!isInitialListReadyNotified && viewTreeObserver != null) {
+            viewTreeObserver.removeOnPreDrawListener(preDrawListener);
+        }
     }
 
     @Override