fix(ios): fix weak ref issue in closure

Tencent · Nov 30, 2023 · 182ce4e · 182ce4e
1 parent acce0e6
commit 182ce4e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/renderer/native/ios/renderer/HippyUIManager.mm b/renderer/native/ios/renderer/HippyUIManager.mm
@@ -416,10 +416,10 @@ - (void)setFrame:(CGRect)frame forView:(UIView *)view{
     }
     __weak id weakSelf = self;
     std::vector<std::function<void()>> ops_ = {[hippyTag, rootTag, weakSelf, frame]() {
-        if (!weakSelf) {
+        HippyUIManager *strongSelf = weakSelf;
+        if (!strongSelf) {
             return;
         }
-        HippyUIManager *strongSelf = weakSelf;
         HippyShadowView *renderObject = [strongSelf->_shadowViewRegistry componentForTag:hippyTag onRootTag:rootTag];
         if (renderObject == nil) {
             return;
@@ -444,10 +444,10 @@ - (void)setFrame:(CGRect)frame forRootView:(UIView *)view {
     }
     __weak id weakSelf = self;
     std::vector<std::function<void()>> ops_ = {[componentTag, weakSelf, frame]() {
-        if (!weakSelf) {
+        HippyUIManager *strongSelf = weakSelf;
+        if (!strongSelf) {
             return;
         }
-        HippyUIManager *strongSelf = weakSelf;
         HippyShadowView *renderObject = [strongSelf->_shadowViewRegistry rootComponentForTag:componentTag];
         if (renderObject == nil) {
             return;

diff --git a/renderer/native/ios/renderer/component/view/HippyShadowView.mm b/renderer/native/ios/renderer/component/view/HippyShadowView.mm
@@ -329,10 +329,10 @@ - (void)setLayoutFrame:(CGRect)frame dirtyPropagation:(BOOL)dirtyPropagation {
         __weak HippyShadowView *weakSelf = self;
         std::vector<std::function<void()>> ops = {[weakSelf, domManager, frame, dirtyPropagation](){
             @autoreleasepool {
-                if (!weakSelf) {
+                HippyShadowView *strongSelf = weakSelf;
+                if (!strongSelf) {
                     return;
                 }
-                HippyShadowView *strongSelf = weakSelf;
                 int32_t componentTag = [[strongSelf hippyTag] intValue];
                 auto node = domManager->GetNode(strongSelf.rootNode, componentTag);
                 auto renderManager = domManager->GetRenderManager().lock();