fix(vue): fix rootview conditional statement (#3355)

* fix(vue): fix rootview conditional statement * fix(test): fix js build test * fix(test): fix js build test * fix(test): fix js build test
Tencent · Jul 25, 2023 · 5364548 · 5364548
1 parent 8b3f572
commit 5364548
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/.github/workflows/frontend_build_tests.yml b/.github/workflows/frontend_build_tests.yml
@@ -32,7 +32,8 @@ jobs:
           cache: 'npm'
           cache-dependency-path: driver/js/package-lock.json
       - name: install
-        run: npm ci && lerna bootstrap --no-ci
+        run: |
+          npm install && npx lerna bootstrap --no-ci
       - name: lint & build
         run: npm run lint & npm run build
       - name: test

diff --git a/driver/js/packages/hippy-vue/src/runtime/node-ops.js b/driver/js/packages/hippy-vue/src/runtime/node-ops.js
@@ -20,7 +20,6 @@
 
 import document from '../renderer/document-node';
 import { unCacheNodeOnIdle } from '../util/node';
-import { getApp } from '../util';
 import { setAttrs } from './modules/attrs';
 import { setStyle } from './modules/style';
 import { setClass } from './modules/class';
@@ -34,12 +33,6 @@ function setRootViewAttr(elm, vnode) {
   let isRootView = false;
   if (elm.nodeId === ROOT_VIEW_ID) {
     isRootView = true;
-  } else if (vnode && vnode.data && vnode.data.attrs && vnode.data.attrs.id) {
-    const app  = getApp();
-    if (app) {
-      const { $options: { rootView } } = app;
-      isRootView = vnode.data.attrs.id === rootView.slice(1 - rootView.length);
-    }
   }
   if (isRootView) {
     setAttrs(vnode, elm, { notToNative: true });