fix(hippy-react): fix declaration for animation and scroll-view

Tencent · Sep 13, 2023 · 5ff1bc9 · 5ff1bc9
1 parent c76ac57
commit 5ff1bc9
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 14 deletions.
diff --git a/packages/hippy-react/src/components/scroll-view.tsx b/packages/hippy-react/src/components/scroll-view.tsx
@@ -27,7 +27,29 @@ import Element from '../dom/element-node';
 import { isRTL } from '../utils/i18n';
 import View from './view';
 
-export interface ScrollViewProps {
+interface ScrollViewPropsIOS {
+
+  /**
+   * When `true`, shows a horizontal scroll indicator.
+   * Default: true
+   */
+  showsHorizontalScrollIndicator?: boolean;
+
+  /**
+   * When `true`, shows a vertical scroll indicator.
+   * Default: true
+   */
+  showsVerticalScrollIndicator?: boolean;
+}
+
+interface ScrollViewPropsAndroid {
+  /**
+   * When false, the scroll view will hide scroll indicator
+   * @default false
+   */
+  showScrollIndicator?: boolean;
+}
+export interface ScrollViewProps extends ScrollViewPropsAndroid, ScrollViewPropsIOS {
   // TODO: allow HippyTypes.Style[]
   style?: HippyTypes.Style;
   /**
@@ -52,18 +74,6 @@ export interface ScrollViewProps {
    */
   scrollEnabled?: boolean;
 
-  /**
-   * When `true`, shows a horizontal scroll indicator.
-   * Default: true
-   */
-  showsHorizontalScrollIndicator?: boolean;
-
-  /**
-   * When `true`, shows a vertical scroll indicator.
-   * Default: true
-   */
-  showsVerticalScrollIndicator?: boolean;
-
   /**
    * These styles will be applied to the scroll view content container which wraps all
    * of the child views.

diff --git a/packages/hippy-react/src/modules/animation.ts b/packages/hippy-react/src/modules/animation.ts
@@ -59,7 +59,7 @@ interface AnimationOptions {
    * Value type, leave it blank in most case, except use rotate/color related
    * animation, set it to be 'deg' or 'color'.
    */
-  valueType?: 'deg'; // TODO: fill more options
+  valueType?: 'deg' | 'rad' | 'color'; // TODO: fill more options
 
   /**
    * Animation start position